Skip to content

Conversation

@DHKIM-0511
Copy link

@DHKIM-0511 DHKIM-0511 commented Nov 10, 2024

close #1601

someone did not want add empty user text on chat memory

so, I fix chat advisor to not add message when user text is empty

@ThomasVitale
Copy link
Contributor

Thanks for submitting this PR! This shouldn't be needed anymore since we introduced null-safety for ChatClient and Advisor APIs, and removed the default empty user text. The user message is now required and it will never be null or empty in the context of an Advisor.

@DHKIM-0511
Copy link
Author

Thanks for submitting this PR! This shouldn't be needed anymore since we introduced null-safety for ChatClient and Advisor APIs, and removed the default empty user text. The user message is now required and it will never be null or empty in the context of an Advisor.

Oh, I see. I'm also curious about other possible solutions—would it be possible to check the commit history to see how it was implemented? Thanks for your kind response!

@ThomasVitale
Copy link
Contributor

Yes, of course! Most changes are in this PR: #1651

@ThomasVitale
Copy link
Contributor

@DHKIM-0511 we have an open discussion about making the logic of identifying a user message more flexible, while still ensuring internal consistency. If you have some use cases or ideas related to that, feel free to share them in #1665 Thanks!

@DHKIM-0511
Copy link
Author

DHKIM-0511 commented Nov 11, 2024

Looking at the PR. I understand now that the feature is no longer needed. I’ll also consider the issue #1665. Thanks!

@DHKIM-0511 DHKIM-0511 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MessageChatMemoryAdvisor adds empty user message

2 participants