From 749dde902ae507d414c276fd88c9b2e36fdc3363 Mon Sep 17 00:00:00 2001 From: Hyoseop Song Date: Wed, 20 Nov 2024 10:41:08 +0900 Subject: [PATCH] standardized logger parameter bind type-assured Signed-off-by: loveysuby --- .../springframework/ai/evaluation/BasicEvaluationTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spring-ai-test/src/main/java/org/springframework/ai/evaluation/BasicEvaluationTest.java b/spring-ai-test/src/main/java/org/springframework/ai/evaluation/BasicEvaluationTest.java index ea056cca3f9..43f497f1f50 100644 --- a/spring-ai-test/src/main/java/org/springframework/ai/evaluation/BasicEvaluationTest.java +++ b/spring-ai-test/src/main/java/org/springframework/ai/evaluation/BasicEvaluationTest.java @@ -56,8 +56,8 @@ public class BasicEvaluationTest { protected void evaluateQuestionAndAnswer(String question, String answer, boolean factBased) { assertThat(question).isNotNull(); assertThat(answer).isNotNull(); - logger.info("Question: " + question); - logger.info("Answer:" + answer); + logger.info("Question: {}", question); + logger.info("Answer:{}", answer); PromptTemplate userPromptTemplate = new PromptTemplate(this.userEvaluatorResource, Map.of("question", question, "answer", answer)); SystemMessage systemMessage; @@ -70,7 +70,7 @@ protected void evaluateQuestionAndAnswer(String question, String answer, boolean Message userMessage = userPromptTemplate.createMessage(); Prompt prompt = new Prompt(List.of(userMessage, systemMessage)); String yesOrNo = this.openAiChatModel.call(prompt).getResult().getOutput().getContent(); - logger.info("Is Answer related to question: " + yesOrNo); + logger.info("Is Answer related to question: {}", yesOrNo); if (yesOrNo.equalsIgnoreCase("no")) { SystemMessage notRelatedSystemMessage = new SystemMessage(this.qaEvaluatorNotRelatedResource); prompt = new Prompt(List.of(userMessage, notRelatedSystemMessage));