Skip to content

Conversation

@tzolov
Copy link
Contributor

@tzolov tzolov commented Nov 20, 2024

  • Replace hardcoded "tool_use" with StopReason enum value
  • Add tests for token usage aggregation with tool calls
  • Add handling for null response metadata

Related to #1763 - Adds requested tests

…tion tests

- Replace hardcoded "tool_use" with StopReason enum value
- Add tests for token usage aggregation with tool calls
- Add handling for null response metadata
@ilayaperumalg
Copy link
Member

LGTM, merging.

@ilayaperumalg ilayaperumalg self-assigned this Nov 20, 2024
@ilayaperumalg ilayaperumalg merged commit 551206f into spring-projects:main Nov 20, 2024
1 check passed
leijendary pushed a commit to leijendary/spring-ai that referenced this pull request Jan 24, 2025
…tion tests (spring-projects#1777)

- Replace hardcoded "tool_use" with StopReason enum value
- Add tests for token usage aggregation with tool calls
- Add handling for null response metadata

Signed-off-by: leijendary <[email protected]>
leijendary pushed a commit to leijendary/spring-ai that referenced this pull request Jan 24, 2025
…tion tests (spring-projects#1777)

- Replace hardcoded "tool_use" with StopReason enum value
- Add tests for token usage aggregation with tool calls
- Add handling for null response metadata

Signed-off-by: leijendary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants