Skip to content

feat(gemini) Support Safety Settings for VertexAiGeminiChatModel #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(gemini) Support Safety Settings for VertexAiGeminiChatModel #1803

wants to merge 1 commit into from

Conversation

@terussell85
Copy link
Contributor

@terussell85 terussell85 commented Nov 23, 2024 •
edited
Loading

Adds support for SafetySettings configuration to VertexAiGeminiChatModel and VertexAiGeminiChatOptions

See https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/configure-safety-filters for reference.

Should fix #942

@tzolov tzolov added this to the 1.0.0-M5 milestone Nov 24, 2024
@tzolov tzolov self-assigned this Nov 24, 2024
@terussell85
Copy link
Contributor Author

terussell85 commented Nov 25, 2024

@tzolov I updated the code with updates from the spring-javaformat plugin. Apologies that I didn't catch that the first time.

tzolov
tzolov reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terussell85 , thank you, for the important contribution!

I've left couple of comments. The most important one is to verify if we can use the spring.ai.vertex.ai.gemini.chat.options.SafetySetting to configure the SafetySettings declaratively via app. properties. You can check the auto-config ITs here.

Also can you please check if you can update the VertexAIGemini docs here.
You can build the docs locally with: ./mvnw -pl spring-ai-docs antora .

@terussell85
Copy link
Contributor Author

terussell85 commented Nov 26, 2024

Great feedback. I'll take a look and get back to you.

@terussell85
feat(gemini) Support Safety Settings for VertexAiGeminiChatModel
e8e65ec 
feat(gemini) not null checks on safetySettings

feat(gemini) check safety settings not empty instead of not null

feat(gemini) Add VertexAiGeminiSafetySetting wrapper class

feat(gemini) Update documentation with new property

feat(gemini) Update equals, hashCode, and toString
@terussell85
Copy link
Contributor Author

terussell85 commented Dec 4, 2024 •
edited
Loading

@tzolov I think we're good to go now.

Changes since last review:

  1. Introduce new VertexAiGeminiSafetySetting class to allow for declarative configuration. This is converted to the Vertex AI setting at request-time.
  2. Not null assertions for safetySettings on both the Builder and the class property.
  3. Verified that declarative configuration works
  4. Updated docs

I made some changes to the originally suggested SafetySetting class, including renaming it and adding a Builder. I also kept the newly defined Spring enums both value- and name-consistent with the Gemini enums so that there won't be accidental confusion of users.

Let me know if there is anything else.

@terussell85 terussell85 requested a review from tzolov December 4, 2024 19:12
@tzolov
Copy link
Contributor

tzolov commented Dec 17, 2024

thanks @terussell85

@tzolov
Copy link
Contributor

tzolov commented Dec 17, 2024

rebased and merged at c14618f

@tzolov tzolov closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markpollack markpollack markpollack left review comments

@tzolov tzolov Awaiting requested review from tzolov

Assignees

@tzolov tzolov

Labels

chat options enhancement New feature or request gcp gemini vertex

Projects

None yet

Milestone

1.0.0-M5

Development

Successfully merging this pull request may close these issues.

VertexAiGeminiChatModel: Make safetySettings configurable

3 participants

@terussell85 @tzolov @markpollack