Portable ChatOptions ignored by OpenAiChatModel #1835
Conversation
When calling the OpenAiChatModel with ChatOptions, they are always ignored. Options are considered only when using OpenAiChatOptions or FunctionCallingOptions. Signed-off-by: Thomas Vitale <[email protected]>
| FunctionCallingOptions.class, OpenAiChatOptions.class); | ||
| } | ||
| else if (prompt.getOptions() instanceof OpenAiChatOptions) { | ||
| else { |
There was a problem hiding this comment.
This is the same implementation as all the other model integrations. The problem was only in OpenAI.
|
I've noticed this issue last week. Initially the |
|
@tzolov I haven't seen the bug in the other chat implementations since they all already have an "else" statement that makes sure the portable options are mapped correctly. Can we get the bug fixed in OpenAI with this PR and then have the refactoring to improve the logic in a separate issue, now that |
|
@ThomasVitale i guess you are right. I was concerned about the order, but it correct (e.g. from more specific to the generic type) |
2 participants
When calling the
OpenAiChatModelwithChatOptions, they are always ignored. Options are considered only when usingOpenAiChatOptionsorFunctionCallingOptions.This seems a regression after the recent refactoring of
FunctionCallingOptions. I checked all the model implementation and it's only OpenAI having this error.