Skip to content

Conversation

@youngmoneee
Copy link
Contributor

implemented stub method

Resolves #1857

@ilayaperumalg
Copy link
Member

@mxsl-gr Could you verify this PR? Thanks!

@youngmoneee youngmoneee force-pushed the fix#1857 branch 2 times, most recently from 2a13891 to 5bd52b7 Compare February 6, 2025 07:28
implemented stub method

Signed-off-by: youngmoneee <[email protected]>
@mxsl-gr
Copy link
Contributor

mxsl-gr commented Feb 11, 2025

@mxsl-gr Could you verify this PR? Thanks!

@ilayaperumalg
Sorry for the late reply! I just got back from a long trip and hadn't checked my emails. I'll verify this PR in couple days.

Copy link
Contributor

@mxsl-gr mxsl-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay

@ilayaperumalg
Copy link
Member

@mxsl-gr Thanks for the review. @youngmoneee Thanks for your contribution. Unfortunately, similar changes have been merged via #3668 and hence, I am closing this as without merging. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How does zhipu ai embeddings model support dimensions parameters

3 participants