Skip to content

Fix DefaultFunctionCallingOptionsBuilder #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix DefaultFunctionCallingOptionsBuilder #1982

wants to merge 1 commit into from

Conversation

@ilayaperumalg
Copy link
Member

@ilayaperumalg ilayaperumalg commented Dec 19, 2024

  • Reuse DefaultChatOptionsBuilder's options to refer both functioncalling and chat options - Set the parent class options with the FunctionCallingOptions when DefaultFunctionCallingOptionsBuilder is used

@ilayaperumalg
Fix DefaultFunctionCallingOptionsBuilder
fd9720e 
 - Remove DefaultFunctionCallingOptionsBuilder's functionCallingOptions
 - Reuse DefaultChatOptionsBuilder's options to refer both functioncalling and chat options
     - Set the parent class options with the FunctionCallingOptions when DefaultFunctionCallingOptionsBuilder is used
 - Make sure DefaultChatOptionsBuilder(DefaultChatOptions) is protected
@ilayaperumalg ilayaperumalg added this to the 1.0.0-M5 milestone Dec 19, 2024
@markpollack
Copy link
Member

markpollack commented Dec 19, 2024

merged in bfc0b82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@markpollack markpollack

Labels

None yet

Projects

None yet

Milestone

1.0.0-M5

Development

Successfully merging this pull request may close these issues.

2 participants

@ilayaperumalg @markpollack