Skip to content

Fix Qdrant failing test #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Qdrant failing test #1988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rc/test/java/org/springframework/ai/vectorstore/qdrant/QdrantVectorStoreBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ void customConfiguration() {
@Test
void nullQdrantClientInConstructorShouldThrowException() {
assertThatThrownBy(() -> QdrantVectorStore.builder(null, null)).isInstanceOf(IllegalArgumentException.class)
.hasMessage("QdrantClient must not be null");
.hasMessage("EmbeddingModel must be configured");
}

@Test
void nullEmbeddingModelShouldThrowException() {
assertThatThrownBy(() -> QdrantVectorStore.builder(qdrantClient, null).build())
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("EmbeddingModel must not be null");
.hasMessage("EmbeddingModel must be configured");
Copy link
Contributor Author

@ThomasVitale ThomasVitale Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message now is defined in the abstract parent builder, so it differs from the one that used to be defined in QdrantVectorStore itself.

}

@Test
Expand Down
Loading