Standardize builder class names in vector stores #1993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename all specific builder inner classes (PineconeBuilder, MongoDBBuilder, etc.) to simply Builder for consistency across vector store implementations - Update code references to use the new standardized Builder class names The change establishes a consistent naming convention for builder classes across the vector store implementations, improving code uniformity.
Update documentation examples to show correct builder usage across all vector store implementations. Demonstrate passing required parameters directly in builder() method.
markpollack
reviewed
Dec 21, 2024
| return CassandraVectorStore.builder() | ||
| .session(session) | ||
| .embeddingModel(embeddingModel) | ||
| return CassandraVectorStore.builder(embeddingModel) |
Member
There was a problem hiding this comment.
isn't CqlSession a required parameter that should be in the builder signature?
Member
|
merged in d697e58 Will can circle back on the signature for CassandraVectorStore's builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change establishes a consistent naming convention for builder classes across the vector store implementations, improving code uniformity.