Improve inheritance hierarchy of ChatOptions/FunctionCallingOptions #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert ChatOptions.Builder to have `Builder<B extends Builder<B, C>, C extends ChatOptions>` - This will allow the subclasses which extend this builder to provide their implementation of ChatOptions i.e, in our case FunctionCallingOptions - Update the default builder implementations with this change - Update FunctionCallingOptions and its default builder implementation to enforce this hiearchical change
|
I've reimplemented the options builders to get rid of the generics. There were still hard to resolve warnings in the IDE and I kept going in circles. It shouldn't be so complicated but that approach seems to lead to unwanted java generic warning/side effects. Now the approach is very simple and easy to understand. merged new impl in 0765b2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builder<B extends Builder<B, C>, C extends ChatOptions>