Add dimensions option for ZhiPuAi embedding model #2057
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxsl-gr Could you check this PR? Thanks! |
no problem. |
mxsl-gr
approved these changes
Jan 21, 2025
| | spring.ai.zhipuai.embedding.base-url | Optional overrides the spring.ai.zhipuai.base-url to provide embedding specific url | - | ||
| | spring.ai.zhipuai.embedding.api-key | Optional overrides the spring.ai.zhipuai.api-key to provide embedding specific api-key | - | ||
| | spring.ai.zhipuai.embedding.options.model | The model to use | embedding-2 | ||
| | spring.ai.zhipuai.embedding.options.dimensions | The number of dimensions | - |
There was a problem hiding this comment.
maybe it can be added to the doc: the default value is 2048 when the model is embedding-3
There was a problem hiding this comment.
thanks, I will add docs for this option.
|
the unit tests work fine, it might be helpful to add a note about the default value of dimensions in the doc |
Signed-off-by: Assassinxc <[email protected]>
Signed-off-by: Assassinxc <[email protected]>
Assassinxc
force-pushed
the
add-dimensions-options-for-zhipu-embeddings
branch
from
b6b668b to
cacf381
Compare
mxsl-gr
approved these changes
Jan 22, 2025
|
@mxsl-gr Thanks for the review and the approval. Merging the changes. @Assassinxc Thanks for the PR! |
|
Rebased, squashed and merged as 62ce753 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ZhiPuAi embedding-3 model's dimemsions option
https://www.bigmodel.cn/dev/api/vector/embedding