OpenAI - Adopt ToolCallingManager API #2188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThomasVitale
commented
Feb 7, 2025
ThomasVitale
commented
- Update OpenAiChatModel to use the new ToolCallingManager API, while ensuring full API backward compatibility.
- Introduce Builder to instantiate a new OpenAiChatModel since the number of overloaded constructors is growing too big.
- Update documentation about tool calling and OpenAI support for that.
- Add extra validation to ensure the uniqueness of tool names when aggregated from different sources.
ThomasVitale
force-pushed
the
openai-tool-calling
branch
from
b55b494 to
4b1faf4
Compare
ThomasVitale
force-pushed
the
openai-tool-calling
branch
from
4b1faf4 to
6441454
Compare
- Update OpenAiChatModel to use the new ToolCallingManager API, while ensuring full API backward compatibility. - Introduce Builder to instantiate a new OpenAiChatModel since the number of overloaded constructors is growing too big. - Update documentation about tool calling and OpenAI support for that. - Add extra validation to ensure the uniqueness of tool names when aggregated from different sources. - Ensure consistent merging of options, following Spring Boot strategy. Signed-off-by: Thomas Vitale <[email protected]>
ThomasVitale
force-pushed
the
openai-tool-calling
branch
from
6441454 to
7b4f4a4
Compare
Member
|
relates to #2207 epic |
| // We do not pass the 'defaultOptions' to the AbstractToolSupport, | ||
| // because it modifies them. We are using ToolCallingManager instead, | ||
| // so we just pass empty options here. | ||
| super(null, OpenAiChatOptions.builder().build(), List.of()); |
Member
There was a problem hiding this comment.
Do we still need to extend AbstractToolCallSupport class?
Contributor
Author
There was a problem hiding this comment.
We kept that to ensure API backward compatibility, but it will be removed right after M6 is released.
Contributor
|
Rebased and merged at 52198ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.