Add missing integration tests for delete by ID API in vector store im… #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations. Signed-off-by: Soby Chacko <[email protected]>
This commit extracts shared delete operation tests into a reusable BaseVectorStoreTests class. This reduces code duplication and provides a consistent test suite for delete operations across different vector store implementations. The base class includes tests for: Deleting by ID Deleting by filter expressions Deleting by string filter expressions Most of the vector store implementation now extends this base class and inherits these common tests while maintaining the ability to add vector store specific tests. Signed-off-by: Soby Chacko <[email protected]>
sobychacko
force-pushed
the
vec-store-delete-integ-tests
branch
from
71e0e36 to
92cc3b7
Compare
Member
ilayaperumalg
left a comment
ilayaperumalg
left a comment
There was a problem hiding this comment.
Nice refactoring to the vector store ITs!
| */ | ||
| public abstract class BaseVectorStoreTests { | ||
|
|
||
| protected abstract void executeTest(Consumer<VectorStore> testFunction); |
Member
There was a problem hiding this comment.
A javadoc here on what to expect for the implementations would be helpful
Signed-off-by: Soby Chacko <[email protected]>
Member
|
Rebased, squashed and merged as 4d692a5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plementations.