Fix bug #2301. The SseHttpClientTransportAutoConfiguration will always run for the class name in @ConditionalOnMissingClass is wrong. #2305
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…tion will always run for the class name in @ConditionalOnMissingClass is wrong. Signed-off-by: Mota <[email protected]>
Author
Contributor
|
Thank you @banalite. I'm afraid this test isn't doing much as the sseHttpClientTransportAutoConfiguration is not a bean so it will never be present? |
Contributor
|
Replaced by #2451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reason in the title, using McpSyncClient to list tools will always failed. As there will be two NamedClientMcpTransports connect to one same server, then will be duplicate tool names from McpSyncClient.listTools(), and this will not pass the check in SyncMcpToolCallbackProvider.validateToolCallbacks(ToolCallback[] toolCallbacks).