Skip to content

Conversation

@apappascs
Copy link
Contributor

@apappascs apappascs commented Mar 2, 2025

This commit enhances AzureOpenAiChatOptions by:

  • Adding equals and hashCode methods for proper object comparison.
  • Implementing a deep copy() method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state.
  • Adding AzureOpenAiChatOptionsTests to verify copy(), builders, setters, and default values.

- Adding `equals` and `hashCode` methods for proper object comparison.
- Implementing a deep `copy()` method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state.
- Adding `AzureOpenAiChatOptionsTests` to verify `copy()`, builders, setters, and default values.

Signed-off-by: Alexandros Pappas <[email protected]>
@apappascs apappascs changed the title This commit enhances AzureOpenAiChatOptions by: feat: Add equals, hashCode, deep copy, and tests to AzureChatOptions Mar 2, 2025
@tzolov tzolov self-assigned this Mar 13, 2025
@tzolov tzolov added this to the 1.0.0-M7 milestone Mar 13, 2025
@tzolov
Copy link
Contributor

tzolov commented Mar 13, 2025

Thank you @apappascs
rebased and merged at bc375ab

@tzolov tzolov closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants