Fix PgVectorStore doDelete function as batch update #2434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CChuYong Thanks for the PR fixing the issue. Could you add a test to validate the fix? |
CChuYong
force-pushed
the
fix-id-type-in-pgvector-store
branch
from
4715998 to
ea4632b
Compare
|
@ilayaperumalg Sure! i added a test for testing bulk operations of PgVectorStore with different types of id. |
CChuYong
force-pushed
the
fix-id-type-in-pgvector-store
branch
from
ea4632b to
711ac1d
Compare
| } | ||
|
|
||
| @Test | ||
| public void testBulkOperationWithUuidIdType() { |
There was a problem hiding this comment.
Thanks for adding the test. This test runs fine when running as a standalone but fails when all the tests within this class run. Looks like some race condition there. Could you check?
There was a problem hiding this comment.
Thanks for your review!
i figured out that getNativeClientTest also initializes vector table, so i also added code for dropping table in getNativeClientTest. fb829af
Signed-off-by: CChuYong <[email protected]>
CChuYong
force-pushed
the
fix-id-type-in-pgvector-store
branch
from
711ac1d to
fb829af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes fixing minor issues on
PgVectorStore.doDelete().PgVectorStorecan handle different kind of IdTypes from Fix Handling of UUID and Other ID Formats in PgVectorStore #2111.doDelete()function only accepts UUID, so method will throwIllegalArgumentExceptionwhen id type isn't UUID.convertIdToPgType()function to correctly map id types.JdbcTemplate.batchUpdate()to delete bulk of ids.