Skip to content

Conversation

@Fj-ivy
Copy link
Contributor

@Fj-ivy Fj-ivy commented Mar 12, 2025

fix SyncMcpToolCallback call method NPE when response error is null

@tzolov
Copy link
Contributor

tzolov commented Mar 12, 2025

Nice catch @Fj-ivy Can you please apply the same fix to the AsyncMcpToolCallback?

@tzolov tzolov added the MCP label Mar 12, 2025
@tzolov tzolov added this to the 1.0.0-M7 milestone Mar 12, 2025
@tzolov tzolov self-assigned this Mar 12, 2025
@tzolov
Copy link
Contributor

tzolov commented Mar 12, 2025

@Fj-ivy, can you elaborate on when do you see this NPE? Is it a particular server missing to set it?

@Fj-ivy
Copy link
Contributor Author

Fj-ivy commented Mar 12, 2025

@Fj-ivy, can you elaborate on when do you see this NPE? Is it a particular server missing to set it?

Steps to reproduce refer this issue #2447.

@tzolov
Copy link
Contributor

tzolov commented Mar 12, 2025

@Fj-ivy, can you elaborate on when do you see this NPE? Is it a particular server missing to set it?

Steps to reproduce refer this issue #2447.

I see. We can not assume that all MCP servers implementations will be spec compliant.

@tzolov
Copy link
Contributor

tzolov commented Mar 12, 2025

Ok, I will fix the AsyncMcpToolCallback will merging this PR

@tzolov
Copy link
Contributor

tzolov commented Mar 12, 2025

Extended, rebased, squashed and merged at 127f700

@tzolov tzolov closed this Mar 12, 2025
@Fj-ivy Fj-ivy deleted the patch-1 branch March 12, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants