Skip to content

SyncMcpToolCallback call method NPE #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

SyncMcpToolCallback call method NPE #2452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec39fba
SyncMcpToolCallback call method NPE
Fj-ivy Mar 12, 2025
5771a98
SyncMcpToolCallback call method NPE
Fj-ivy Mar 12, 2025
94d23f1
Merge remote-tracking branch 'github-desktop-Fj-ivy/patch-1' into pr/…
Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mcp/common/src/main/java/org/springframework/ai/mcp/SyncMcpToolCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public String call(String functionInput) {
// Note that we use the original tool name here, not the adapted one from
// getToolDefinition
CallToolResult response = this.mcpClient.callTool(new CallToolRequest(this.tool.name(), arguments));
if (response.isError()) {
if (response.isError() != null && response.isError()) {
throw new IllegalStateException("Error calling tool: " + response.content());
}
return ModelOptionsUtils.toJsonString(response.content());
Expand Down