Skip to content

refactor SimpleLoggerAdvisor #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor SimpleLoggerAdvisor #2597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...nt-chat/src/main/java/org/springframework/ai/chat/client/advisor/SimpleLoggerAdvisor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,21 @@
* A simple logger advisor that logs the request and response messages.
*
* @author Christian Tzolov
* @author Jonghoon Park
*/
public class SimpleLoggerAdvisor implements CallAroundAdvisor, StreamAroundAdvisor {

public static final Function<AdvisedRequest, String> DEFAULT_REQUEST_TO_STRING = request -> request.toString();
public static final Function<AdvisedRequest, String> DEFAULT_REQUEST_TO_STRING = Record::toString;

public static final Function<ChatResponse, String> DEFAULT_RESPONSE_TO_STRING = response -> ModelOptionsUtils
.toJsonStringPrettyPrinter(response);
public static final Function<ChatResponse, String> DEFAULT_RESPONSE_TO_STRING = ModelOptionsUtils::toJsonStringPrettyPrinter;

private static final Logger logger = LoggerFactory.getLogger(SimpleLoggerAdvisor.class);

private final Function<AdvisedRequest, String> requestToString;

private final Function<ChatResponse, String> responseToString;

private int order;
private final int order;

public SimpleLoggerAdvisor() {
this(DEFAULT_REQUEST_TO_STRING, DEFAULT_RESPONSE_TO_STRING, 0);
Expand All @@ -60,6 +60,11 @@ public SimpleLoggerAdvisor(int order) {
this(DEFAULT_REQUEST_TO_STRING, DEFAULT_RESPONSE_TO_STRING, order);
}

public SimpleLoggerAdvisor(Function<AdvisedRequest, String> requestToString,
Function<ChatResponse, String> responseToString) {
this(requestToString, responseToString, 0);
}

public SimpleLoggerAdvisor(Function<AdvisedRequest, String> requestToString,
Function<ChatResponse, String> responseToString, int order) {
this.requestToString = requestToString;
Expand Down