Add auto-registration support for MethodToolCallbackProvider using @Tool #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitokim
force-pushed
the
GH-2632
branch
3 times, most recently
from
e79c6c6 to
4aa97ac
Compare
|
Improve the process so that each Tool method doesn’t need to be registered manually with MethodToolCallbackProvider. |
Signed-off-by: jitokim <[email protected]>
- Add @EnableToolCallbackAutoRegistration to enable auto-registration - Add ToolCallbackAutoRegistrar using ImportBeanDefinitionRegistrar - Add ToolAnnotatedBeanProcessor to collect @Tool-annotated methods and register a MethodToolCallbackProvider Signed-off-by: jitokim <[email protected]>
…re specified Signed-off-by: jitokim <[email protected]>
Signed-off-by: jitokim <[email protected]>
…clarity This commit refactors `ToolCallbackAutoRegistrar` to improve its reliability, clarity, and initialization process. Key changes include: - Consolidated tool callback registration logic by integrating responsibilities from the (now removed) `ToolAnnotatedBeanProcessor`. This simplifies the auto-configuration flow for @tool annotated methods. - Deferred tool scanning and `MethodToolCallbackProvider` registration until `ApplicationReadyEvent`. This ensures that the operation occurs only after the application context and all relevant beans are fully initialized, enhancing stability. Signed-off-by: jitokim <[email protected]>
|
962d2ed rebase & refactor |
|
@ilayaperumalg outdated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses spring-projects/spring-ai#2632.