-
Notifications
You must be signed in to change notification settings - Fork 2k
Add filter query support for GemFireVectorStore #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jason Huynh <[email protected]>
59e9a2a
to
3e713b8
Compare
Hi @markpollack , this is a PR for adding filter queries to GemFireVectorStore. Thanks! |
@jhuynh1 I am reviewing this PR. The new test in |
Hi, @sobychacko we have pushed a commit to the PR to fix the failing test. The failing test is passing now. Please do test it and let us know, if there is anything else we can do to get this merged. Thank you again |
5bd5d16
to
b2c7baa
Compare
Signed-off-by: Nabarun Nag <[email protected]>
b2c7baa
to
2ed72a3
Compare
@nabarunnag Thank you for looking into it. I see that you enabled the IT test by default. I am still getting an exception when trying to run the test suite? Do you recognize anything from the following stack trace? Also, could you rebase your PR with the latest main branch? Thanks!
|
* Disabling the test due to inconsistencies with testcontainers in different test environment. Signed-off-by: Nabarun Nag <[email protected]>
Hi @sobychacko , thank you so much for your time.
Please do reach out if there is any else we can do to get this merged. Thank you! |
Hi @sobychacko, I hope you are doing well. Just wanted to check in and see if we need to do anything else to get this merged. Thank you for your time. |
Hi @sobychacko, checking in to see if we need to do anything else to get this merged. |
@nabarunnag My apologies for not getting back to this PR sooner. It fell off of our radar due to other commitments and once again, sorry. I just merged this PR to upstream |
No description provided.