Mark the builder methods in OpenAiImageOptions.Builder that start with with as @Deprecated.
#2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith 'with' as '@deprecated' Signed-off-by: jonghoonpark <[email protected]>
dev-jonghoonpark
force-pushed
the
deprecate-with-methods
branch
from
4a5a5b5 to
501d6c3
Compare
|
Since we are going to RC, we will remove these as there isn't a deprecation cycle left. |
|
Updated the class and test to match with OpenAiChatOptions merged in 9ca3a7d tx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAiImageOptions.Builderthat start withwithas@Deprecated.withprefix from builder methods, as described in PR Refactor OpenAI chat options #1939, was not fully completed for theOpenAiImageOptionsclass.