Skip to content

Fix: Initialize TokenTextSplitter Builder fields with default values #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: Initialize TokenTextSplitter Builder fields with default values #3167

wants to merge 1 commit into from

Conversation

@ChoHadam
Copy link
Contributor

@ChoHadam ChoHadam commented May 14, 2025 •
edited
Loading

Description

  • Fix the TokenTextSplitter's Builder pattern by properly initializing fields with default values.

Related Issue

@markpollack markpollack added this to the 1.0.0 milestone May 14, 2025
@ilayaperumalg
Copy link
Member

ilayaperumalg commented May 14, 2025

@ChoHadam Thanks for the PR fixing the TokenTextSplitter builder

@ilayaperumalg
Copy link
Member

ilayaperumalg commented May 14, 2025

Rebased and merged as d5d907b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ilayaperumalg ilayaperumalg

Labels

ETL

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

TokenTextSplitter Builder pattern fails when only some parameters are set

3 participants

@ChoHadam @ilayaperumalg @markpollack