Add MySQL schema for SPRING_AI_CHAT_MEMORY
#3320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
Although there is a
MysqlChatMemoryRepositoryDialectfor the JDBC chat memory repository, auto-configuration of the repository currently fails to initialize the table in MySQL databases.When schema initialization is enabled, the application fails with the message:
Among other schema files, there is a
schema-mariadb.sql, but this file doesn't work with MySQL as MySQL doesn't supportCREATE INDEXwithIF NOT EXISTS.Proposed change
This pull request
schema-mysql.sql,JdbcChatMemoryRepositoryMysqlIT, which tests against MariaDB, toJdbcChatMemoryRepositoryMariaDbIT,JdbcChatMemoryRepositoryMysqlIT, which tests against MySQL.Remarks on the MySQL schema
In the MySQL schema, I've used the column type
ENUMinstead of a check constraint. A check constraint would also work in recent MySQL releases, as they have been added in MySQL 8.0.16. But using anENUMextends compatibility even back to MySQL 5.7 and is also a more direct representation of the Java EnumMessageType.