Fixed GH-3557, Fixed the issue where the filename was lost when requesting the OpenAI audio processing interface. #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lename was lost when requesting the OpenAI `/transcriptions` and `/translations` interfaces. Signed-off-by: Sun Yuhan <[email protected]>
Member
|
@sunyuhan1998 Thanks for the PR! |
Member
|
@sunyuhan1998 Thanks for the PR fixing the issue. Rebased and merged as af07517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, there is currently a problem where the filename gets overwritten when requesting OpenAI's
/audio/translationsand/audio/transcriptionsinterfaces, leading to request failures.The root cause lies in the code prior to this PR, specifically in the
org.springframework.ai.openai.OpenAiAudioTranscriptionModel#createRequestmethod. When converting theResourceto abyte[], the original filename information was lost, resulting in a hardcoded filename "audio.webm" being used when sending requests to the OpenAI API, which is clearly unreasonable.This PR fixes the issue by preserving and passing the original filename to the REST interface.
Fixed #3557