Reuse DocumentRowMapper instance to reduce redundant object creation #3564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jonghoonpark
force-pushed
the
reuse-document-row-mapper-instance
branch
2 times, most recently
from
8847f2c to
95550e6
Compare
Signed-off-by: jonghoonpark <[email protected]>
dev-jonghoonpark
force-pushed
the
reuse-document-row-mapper-instance
branch
from
95550e6 to
017d8f3
Compare
spring-builds
pushed a commit
that referenced
this pull request
Jun 17, 2025
Fixes #3564 Signed-off-by: jonghoonpark <[email protected]> (cherry picked from commit af1ce67)
Member
|
@dev-jonghoonpark Thanks for the PR cleaning up the code. |
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Fixes spring-projects#3564 Auto-cherry-pick to 1.0.x Signed-off-by: jonghoonpark <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Fixes spring-projects#3564 Auto-cherry-pick to 1.0.x Signed-off-by: jonghoonpark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of creating a new
DocumentRowMapperinstance on every call to thedoSimilaritySearch()method.DocumentRowMapperis a stateless RowMapper and does not need to be created repeatedly.In this PR,
DocumentRowMapperhas been declared as a final field of the class, initialized once during instance creation, and reused across subsequent calls.Additionally, the unused variable
COLUMN_EMBEDDING, defined in theDocumentRowMapperclass, has been removed.This variable became unused as a result of #1826 and the corresponding ebd29e0.