Remove unused messageHistory
#3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunKui Lu <[email protected]>
YunKuiLu
commented
Jun 17, 2025
Comment on lines
-156
to
-159
| List<Message> messageHistory = new ArrayList<>(prompt.copy().getInstructions()); | ||
| messageHistory.add(new AssistantMessage(assistantMessage.getText(), assistantMessage.getMetadata(), | ||
| assistantMessage.getToolCalls())); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The messageHistory in the buildToolContext method is actually unused. The real messageHistory construction happens in the buildConversationHistoryBeforeToolExecution method.
private static List<Message> buildConversationHistoryBeforeToolExecution(Prompt prompt,
AssistantMessage assistantMessage) {
List<Message> messageHistory = new ArrayList<>(prompt.copy().getInstructions());
messageHistory.add(new AssistantMessage(assistantMessage.getText(), assistantMessage.getMetadata(),
assistantMessage.getToolCalls()));
return messageHistory;
}
YunKuiLu
changed the title
messageHistory
sunyuhan1998
approved these changes
Jun 18, 2025
spring-builds
pushed a commit
that referenced
this pull request
Jun 18, 2025
Fixes #3574 Signed-off-by: YunKui Lu <[email protected]> (cherry picked from commit 3b94838)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3574 Signed-off-by: YunKui Lu <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3574 Signed-off-by: YunKui Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.