Fixed GH-3577, Fixed the error in the PgVectorFilterExpressionConverter when parsing expressions.
#3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verter when parsing nested `And` and `Or` expressions, and added corresponding unit tests. Signed-off-by: Sun Yuhan <[email protected]>
sunyuhan1998
changed the title
PgVectorFilterExpressionConverter when parsing expressions.PgVectorFilterExpressionConverter when parsing expressions.
|
It was my misunderstanding. We should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, the
PgVectorFilterExpressionConverterhad an operator precedence problem when processing nestedAndandOrexpressions due to missing parentheses.This PR fixes that issue by making the following two adjustments:
PgVectorFilterExpressionConverterto add parentheses when handlingAndandOroperators.Fixed #3577