Fixed GH-3586, Add logging for sensitive word matches in SafeGuardAdvisor.
#3589
Conversation
…tput the matched sensitive words in debug log level when a sensitive word is hit. Signed-off-by: Sun Yuhan <[email protected]>
|
Other than logging the sensitive words, can we also put the matched sensitive words into the |
|
Hi @ilayaperumalg , Can you help review this PR? |
| if (!CollectionUtils.isEmpty(this.sensitiveWords)) { | ||
| String content = chatClientRequest.prompt().getContents(); | ||
| Set<String> hitWords = this.sensitiveWords.stream().filter(content::contains).collect(Collectors.toSet()); | ||
| if (!hitWords.isEmpty()) { |
There was a problem hiding this comment.
hi, for if (!hitWords.isEmpty()).
IMO, If you enter this if (!CollectionUtils.isEmpty(this.sensitiveWords)) branch, the following conditions must be true is. means hitWords is not null.I think this if case can be deleted.
|
@sunyuhan1998 We don't want to log any sensitive information as they are indeed sensitive. Perhaps, you can create a custom advisor for your use case. |
Oh, okay, I see. I think I misunderstood its function before, but now I completely understand. Thank you for the clarification! |
4 participants
As mentioned in the issue, currently when
SafeGuardAdvisormatches sensitive words, there is a lack of logs indicating which sensitive words were matched. This PR adds debug logging for that purpose.Fixes #3586