Skip to content

Add Missing Tests for FileDocumentWriter #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Missing Tests for FileDocumentWriter #3646

wants to merge 1 commit into from

Conversation

@JM-Lab
Copy link
Contributor

@JM-Lab JM-Lab commented Jun 23, 2025

This PR adds the FileDocumentWriterTest class, which includes tests for:

  • Basic file writing using the default constructor
  • Document marker output
  • Append mode file writing
  • Metadata serialization and validation

@ilayaperumalg ilayaperumalg self-assigned this Jun 23, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.x milestone Jun 23, 2025
spring-builds pushed a commit that referenced this pull request Jun 23, 2025
@JM-Lab @spring-builds
Add FileDocumentWriterTest for FileDocumentWriter default constructor…
3bcdb9d 
… and various options

Fixes #3646

Signed-off-by: Jemin Huh <[email protected]>
(cherry picked from commit 089c3eb)
@ilayaperumalg
Copy link
Member

ilayaperumalg commented Jun 23, 2025

@JM-Lab Thanks for the PR adding the tests. Rebased and merged as 089c3eb. Backported into 1.0.x as well.

@spring-builds spring-builds mentioned this pull request Jun 23, 2025
Closed
sunyuhan1998 added a commit to sunyuhan1998/spring-ai that referenced this pull request Jun 24, 2025
@sunyuhan1998
fix: spring-projectsGH-3646 Added a license header for FileDocumentWr…
a55ed7a 
…iterTest

Signed-off-by: Sun Yuhan <[email protected]>
@sunyuhan1998 sunyuhan1998 mentioned this pull request Jun 24, 2025
Merged
ilayaperumalg pushed a commit that referenced this pull request Jun 24, 2025
@sunyuhan1998
fix: GH-3646 Added a license header for FileDocumentWriterTest (#3651)
c81667d 
Auto-cherry-pick to 1.0.x
Fixes #3651

Signed-off-by: Sun Yuhan <[email protected]>
Co-authored-by: Sun Yuhan <[email protected]>
spring-builds pushed a commit that referenced this pull request Jun 24, 2025
@sunyuhan1998 @spring-builds
fix: GH-3646 Added a license header for FileDocumentWriterTest (#3651)
75d4e6f 
Fixes #3651

Signed-off-by: Sun Yuhan <[email protected]>
Co-authored-by: Sun Yuhan <[email protected]>
(cherry picked from commit c81667d)
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@JM-Lab @scionaltera
Add FileDocumentWriterTest for FileDocumentWriter default constructor…
bca5b7f 
… and various options

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3646

Signed-off-by: Jemin Huh <[email protected]>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@sunyuhan1998 @scionaltera
fix: spring-projectsGH-3646 Added a license header for FileDocumentWr…
60915c3 
…iterTest (spring-projects#3651)

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3651

Signed-off-by: Sun Yuhan <[email protected]>
Co-authored-by: Sun Yuhan <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@JM-Lab @chedim
Add FileDocumentWriterTest for FileDocumentWriter default constructor…
0fee498 
… and various options

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3646

Signed-off-by: Jemin Huh <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@sunyuhan1998 @chedim
fix: spring-projectsGH-3646 Added a license header for FileDocumentWr…
5591963 
…iterTest (spring-projects#3651)

Auto-cherry-pick to 1.0.x
Fixes spring-projects#3651

Signed-off-by: Sun Yuhan <[email protected]>
Co-authored-by: Sun Yuhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ilayaperumalg ilayaperumalg

Labels

for: backport-to-1.0.x status: backported testing

Projects

None yet

Milestone

1.1.0.M1

Development

Successfully merging this pull request may close these issues.

3 participants

@JM-Lab @ilayaperumalg @spring-builds