[GH-3723] Vertex AI Gemini logprobs support #3724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodrigo Malara <[email protected]>
Closes spring-projectsGH-3723 Signed-off-by: Rodrigo Malara <[email protected]>
| import io.micrometer.observation.contextpropagation.ObservationThreadLocalAccessor; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.springframework.ai.vertexai.gemini.api.VertexAiGeminiApi; |
Contributor
There was a problem hiding this comment.
Please move this line between lines 87 and 88.
...
import org.springframework.ai.tool.definition.ToolDefinition;
import org.springframework.ai.vertexai.gemini.api.VertexAiGeminiApi;
import org.springframework.ai.vertexai.gemini.common.VertexAiGeminiConstants;
...| this.frequencyPenalty, this.presencePenalty, this.maxOutputTokens, this.model, this.responseMimeType, | ||
| this.toolCallbacks, this.toolNames, this.googleSearchRetrieval, this.safetySettings, | ||
| this.internalToolExecutionEnabled, this.toolContext); | ||
| this.internalToolExecutionEnabled, this.toolContext, this.toolContext, this.logprobs, |
Contributor
There was a problem hiding this comment.
Could you please confirm whether the use of this.toolContext twice is intentional?
Contributor
Author
There was a problem hiding this comment.
Good catch! It's not - just removed the extra one.
| @@ -0,0 +1,16 @@ | |||
| package org.springframework.ai.vertexai.gemini.api; | |||
Contributor
There was a problem hiding this comment.
Please add a license header.
Closes spring-projectsGH-3723 Signed-off-by: Rodrigo Malara <[email protected]>
Member
|
@rodrigomalara Thanks for the PR! |
Member
|
@rodrigomalara Thanks for the PR. Rebased and merged as e557081 |
Contributor
Author
Thanks @ilayaperumalg - I see the PR was closed instead of merged but it seems the change is going with 1.1.0. Is it normal procedure or do you have any suggestion so the PR can be merged the next time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.