feat: Make sure that Call/StreamResponseSpec instances can only be used once
#3886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an `AtomicBoolean` to DefaultCallResponseSpec and DefaultStreamResponseSpec to track whether the instance has been used - Check if the instance has already been used before calling `advisorChain.nextCall`, and throw an `IllegalStateException` if it has - Add unit tests to confirm that case Signed-off-by: YunKui Lu <[email protected]>
YunKuiLu
changed the title
XXXResponseSpec instances can only be used onceXXXResponseSpec instances can only be used once
YunKuiLu
changed the title
XXXResponseSpec instances can only be used onceCall/StreamResponseSpec instances can only be used once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicBooleanto DefaultCallResponseSpec and DefaultStreamResponseSpec to track whether the instance has been usedadvisorChain.nextCall, and throw anIllegalStateExceptionif it hasBased on issue #3880, we could add checks to detect if methods in
DefaultCallResponseSpecandDefaultStreamResponseSpecare called more than once, and throw a clear exception to help with debugging.