chore: separate out OllamaOptions into Chat & Embedding Options #3929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethjevans
force-pushed
the
separate-ollama-chat-embedding-options
branch
from
fb02e62 to
46ed2bb
Compare
garethjevans
force-pushed
the
separate-ollama-chat-embedding-options
branch
6 times, most recently
from
8bf1484 to
07f2969
Compare
|
@garethjevans Could you rebase this PR? Thanks! |
|
as this PR has been rebased many times as we never got around to it, we will handle the rebase ourself when the time comes to merge |
Signed-off-by: Gareth Evans <[email protected]>
garethjevans
force-pushed
the
separate-ollama-chat-embedding-options
branch
from
07f2969 to
62506a5
Compare
|
failing on checkstyle validations and there don't appear to be any instructions on how to configure. |
| * @see <a href="https://github.com/ollama/ollama/blob/main/api/types.go">Ollama Types</a> | ||
| */ | ||
| @JsonInclude(Include.NON_NULL) | ||
| public class OllamaEmbeddingOptions implements EmbeddingOptions { |
There was a problem hiding this comment.
@garethjevans Thanks for the PR. Sorry about the delay in getting back to this. Looks like some of the properties like numGPU need to be added to OllamaEmbeddingOptions as well. Could you check?
|
@garethjevans Thanks for the PR. Rebased and merged as f908aa1 along with the changes to include the missing hardware, memory, execution and performance properties into embedding options as well. Verified Ollama ITs with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3926