Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 31, 2025

Overview
This PR adds new test cases to significantly improve the robustness of our Neo4j filter expression converter. These tests cover edge cases and complex scenarios that users encounter in real-world applications.

New Test Cases
Basic Edge Cases:

  • testEmptyList() - IN operations with empty lists
  • testSingleItemList() - IN operations with single items
  • testNullValue() - Equality checks with null values
  • testZeroValue() - Edge case for zero values
  • testEmptyStringValue() - Not-equal comparisons with empty strings

Data Type Handling:

  • testNumericStringValue() - Numeric values stored as strings
  • testMixedDataTypes() - Complex expressions mixing booleans, decimals, strings, and integers
  • testNegativeNumbers() - Negative numeric value handling

Another Scenarios:

  • testNestedJsonPath() - Nested field paths like entity.profile.name
  • testArrayIndexAccess() - Direct array element access like tags[0]
  • testComplexNestedGroups() - Multi-level boolean logic with nested AND/OR groupings
  • testNinWithMixedTypes() - NOT IN operations across different data types

@alxkm alxkm changed the title test: Add comprehensive test coverage for Neo4jVectorFilterExpressionConverter test: Add comprehensive test coverage for Neo4jVectorFilterExpressionConverter Aug 4, 2025
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit b8d8235 into spring-projects:main Aug 6, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants