Skip to content

Keep the same pass check behavior for Evaluator #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Keep the same pass check behavior for Evaluator #3975

merged 1 commit into from
Aug 6, 2025

Conversation

@remeio
Copy link
Contributor

@remeio remeio commented Aug 2, 2025

Keep the same pass check behavior for FactCheckingEvaluator and RelevancyEvaluator, and avoid NPE.

Some test cases:

  • When evaluationResponse is null, return false.
  • When evaluationResponse is yes, return true.
  • When evaluationResponse is Yes, return true.
  • When evaluationResponse is yES, return true.
  • When evaluationResponse is no and yes, return false.
  • When evaluationResponse is yes. , return false.

@remeio
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
70b83f0 
…ancyEvaluator, and avoid NPE.

Signed-off-by: Mengqi Xu <[email protected]>
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit caed4b3 into spring-projects:main Aug 6, 2025
2 checks passed
spring-builds pushed a commit that referenced this pull request Aug 6, 2025
@remeio @spring-builds
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
963b209 
…ancyEvaluator, and avoid NPE. (#3975)

Fixes #3975

Signed-off-by: Mengqi Xu <[email protected]>
(cherry picked from commit caed4b3)
@spring-builds spring-builds mentioned this pull request Aug 6, 2025
Closed
juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
@remeio @juntae6942
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
407b2db 
…ancyEvaluator, and avoid NPE. (spring-projects#3975)

Fixes spring-projects#3975

Auto-cherry-pick to 1.0.x

Signed-off-by: Mengqi Xu <[email protected]>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
@remeio @scionaltera
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
c3aca79 
…ancyEvaluator, and avoid NPE. (spring-projects#3975)

Fixes spring-projects#3975

Auto-cherry-pick to 1.0.x

Signed-off-by: Mengqi Xu <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
@remeio @chedim
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
0c2f0ac 
…ancyEvaluator, and avoid NPE. (spring-projects#3975)

Fixes spring-projects#3975

Auto-cherry-pick to 1.0.x

Signed-off-by: Mengqi Xu <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
@remeio @Willam2004
Keep the same pass check behavior for FactCheckingEvaluator and Relev…
e80c1eb 
…ancyEvaluator, and avoid NPE. (spring-projects#3975)

Fixes spring-projects#3975

Auto-cherry-pick to 1.0.x

Signed-off-by: Mengqi Xu <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

for: backport-to-1.0.x improvement status: backported

Projects

None yet

Milestone

1.1.0.M1

Development

Successfully merging this pull request may close these issues.

3 participants

@remeio @sobychacko @spring-builds