Skip to content

Fix intermittent streaming response aggregation test failure #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Fix intermittent streaming response aggregation test failure #4135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ai-openai/src/test/java/org/springframework/ai/openai/chat/client/OpenAiChatClientIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import org.springframework.util.MimeTypeUtils;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.fail;

@SpringBootTest(classes = OpenAiTestConfiguration.class)
@EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+")
Expand Down Expand Up @@ -235,9 +236,18 @@ void beanStreamOutputConverterRecords() {
.stream()
.filter(cr -> cr.getResult() != null)
.map(cr -> cr.getResult().getOutput().getText())
.filter(text -> text != null && !text.trim().isEmpty()) // Filter out empty/null text
.collect(Collectors.joining());
// @formatter:on

// Add debugging to understand what text we're trying to parse
logger.debug("Aggregated streaming text: {}", generationTextFromStream);

// Ensure we have valid JSON before attempting conversion
if (generationTextFromStream.trim().isEmpty()) {
fail("Empty aggregated text from streaming response - this indicates a problem with streaming aggregation");
}

ActorsFilms actorsFilms = outputConverter.convert(generationTextFromStream);

logger.info("" + actorsFilms);
Expand Down