Use thread safe DateTimeFormatter instead of SimpleDateFormat #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Frizelle <[email protected]>
sunyuhan1998
approved these changes
Aug 18, 2025
spring-builds
pushed a commit
that referenced
this pull request
Aug 20, 2025
Improve type safety in FilterExpressionConverter date parsing - Moved concurrent test into SimpleVectorStoreFilterExpressionConverterTests - Replace var with explicit Instant typing in date parsing logic - Import java.time.Instant for better type safety across all converters Signed-off-by: David Frizelle <[email protected]> Fixes #4172 (cherry picked from commit b4348e6)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Improve type safety in FilterExpressionConverter date parsing - Moved concurrent test into SimpleVectorStoreFilterExpressionConverterTests - Replace var with explicit Instant typing in date parsing logic - Import java.time.Instant for better type safety across all converters Signed-off-by: David Frizelle <[email protected]> Auto-cherry-pick to 1.0.x Fixes spring-projects#4172
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Improve type safety in FilterExpressionConverter date parsing - Moved concurrent test into SimpleVectorStoreFilterExpressionConverterTests - Replace var with explicit Instant typing in date parsing logic - Import java.time.Instant for better type safety across all converters Signed-off-by: David Frizelle <[email protected]> Auto-cherry-pick to 1.0.x Fixes spring-projects#4172
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
Improve type safety in FilterExpressionConverter date parsing - Moved concurrent test into SimpleVectorStoreFilterExpressionConverterTests - Replace var with explicit Instant typing in date parsing logic - Import java.time.Instant for better type safety across all converters Signed-off-by: David Frizelle <[email protected]> Auto-cherry-pick to 1.0.x Fixes spring-projects#4172 Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues in various
FilterExpressionConverterimplementations where the wrong date is sometimes used when being used concurrently due to SimpleDateFormat not being thread safe.Added
testDatesConcurrentlytest case to show that the right dates are now used.