refactor: simplify assistant message extraction using Optional chaining #4416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace nested null checks and redundant branching with streamlined Optional-based approach. Since getResult() == getResults().get(0), processing all results handles both single and multiple result cases. Adding tests to verify. Fixes spring-projects#4292 Signed-off-by: Soby Chacko <[email protected]>
sobychacko
force-pushed
the
gh-4292-updated
branch
from
a6bd11c to
fcb63d8
Compare
|
@sobychacko Thanks for refactoring! LGTM. Rebased and merged as 356fced. Cherry-picked into 1.0.x as 4a4808d. Also, made sure to update the commit to include "Co-Authored-By: eeaters [email protected]" to give credit to the author who submitted the original PR proposing the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace nested null checks and redundant branching with streamlined Optional-based approach. Since getResult() == getResults().get(0), processing all results handles both single and multiple result cases.
Fixes #4292
The original code had an unreachable
elsecondition. This PR attempts to fix this unreachability. Once this PR is merged, we can close this one: #4292