Optimization: remove redundant check on each vector operation #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stroller <[email protected]>
...src/main/java/org/springframework/ai/vectorstore/elasticsearch/ElasticsearchVectorStore.java
Outdated
Show resolved
Hide resolved
Member
|
@jiafu1115 Thanks for the PR! |
Signed-off-by: stroller <[email protected]>
ilayaperumalg
approved these changes
Oct 10, 2025
deejay1
approved these changes
Oct 13, 2025
Contributor
Author
|
@ilayaperumalg update: all reviewer approved and all test passed. Help to merge. thanks |
Member
|
Rebased, squashed and merged via 177cd69 |
Contributor
Author
|
thanks @ilayaperumalg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each vector operation (such as
ElasticsearchVectorStore#doAdd）callsElasticsearchIndicesClient#existsvia an HTTP request to check whether the index exists. This redundant check wastes performance, so a small refactor was performed to eliminate it.