Skip to content

Commit 0fcb772

Browse files
committed
Resolve Sonar Issue
1 parent 2c929ff commit 0fcb772

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/DirectMessageListenerContainer.java

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -340,17 +340,21 @@ private void adjustConsumers(int newCount) {
340340
}
341341
doConsumeFromQueue(queue, index);
342342
}
343-
List<SimpleConsumer> consumerList = this.consumersByQueue.get(queue);
344-
if (consumerList != null && consumerList.size() > newCount) {
345-
int delta = consumerList.size() - newCount;
346-
for (int i = 0; i < delta; i++) {
347-
int index = findIdleConsumer();
348-
if (index >= 0) {
349-
SimpleConsumer consumer = consumerList.remove(index);
350-
if (consumer != null) {
351-
cancelConsumer(consumer);
352-
}
353-
}
343+
reduceConsumersIfIdle(newCount, queue);
344+
}
345+
}
346+
}
347+
348+
private void reduceConsumersIfIdle(int newCount, String queue) {
349+
List<SimpleConsumer> consumerList = this.consumersByQueue.get(queue);
350+
if (consumerList != null && consumerList.size() > newCount) {
351+
int delta = consumerList.size() - newCount;
352+
for (int i = 0; i < delta; i++) {
353+
int index = findIdleConsumer();
354+
if (index >= 0) {
355+
SimpleConsumer consumer = consumerList.remove(index);
356+
if (consumer != null) {
357+
cancelConsumer(consumer);
354358
}
355359
}
356360
}

0 commit comments

Comments
 (0)