GH-1335: Reduce Method Complexity

Author: garyrussell

spring-rabbit/src/main/java/org/springframework/amqp/rabbit/core/RabbitTemplate.java

@@ -1942,28 +1942,7 @@ private Message doSendAndReceiveWithDirect(String exchange, String routingKey, M
 		}
 		DirectReplyToMessageListenerContainer container = this.directReplyToContainers.get(connectionFactory);
 		if (container == null) {
-			synchronized (this.directReplyToContainers) {
-				container = this.directReplyToContainers.get(connectionFactory);
-				if (container == null) {
-					container = new DirectReplyToMessageListenerContainer(connectionFactory);
-					container.setMessageListener(this);
-					container.setBeanName(this.beanName + "#" + this.containerInstance.getAndIncrement());
-					if (this.taskExecutor != null) {
-						container.setTaskExecutor(this.taskExecutor);
-					}
-					if (this.afterReceivePostProcessors != null) {
-						container.setAfterReceivePostProcessors(this.afterReceivePostProcessors
-								.toArray(new MessagePostProcessor[this.afterReceivePostProcessors.size()]));
-					}
-					container.setNoLocal(this.noLocalReplyConsumer);
-					if (this.replyErrorHandler != null) {
-						container.setErrorHandler(this.replyErrorHandler);
-					}
-					container.start();
-					this.directReplyToContainers.put(connectionFactory, container);
-					this.replyAddress = Address.AMQ_RABBITMQ_REPLY_TO;
-				}
-			}
+			container = createReplyToContainer(connectionFactory);
 		}
 		ChannelHolder channelHolder = container.getChannelHolder();
 		boolean cancelConsumer = false;
@@ -1990,6 +1969,33 @@ private Message doSendAndReceiveWithDirect(String exchange, String routingKey, M
 		}
 	}
 
+	private DirectReplyToMessageListenerContainer createReplyToContainer(ConnectionFactory connectionFactory) {
+		DirectReplyToMessageListenerContainer container;
+		synchronized (this.directReplyToContainers) {
+			container = this.directReplyToContainers.get(connectionFactory);
+			if (container == null) {
+				container = new DirectReplyToMessageListenerContainer(connectionFactory);
+				container.setMessageListener(this);
+				container.setBeanName(this.beanName + "#" + this.containerInstance.getAndIncrement());
+				if (this.taskExecutor != null) {
+					container.setTaskExecutor(this.taskExecutor);
+				}
+				if (this.afterReceivePostProcessors != null) {
+					container.setAfterReceivePostProcessors(this.afterReceivePostProcessors
+							.toArray(new MessagePostProcessor[this.afterReceivePostProcessors.size()]));
+				}
+				container.setNoLocal(this.noLocalReplyConsumer);
+				if (this.replyErrorHandler != null) {
+					container.setErrorHandler(this.replyErrorHandler);
+				}
+				container.start();
+				this.directReplyToContainers.put(connectionFactory, container);
+				this.replyAddress = Address.AMQ_RABBITMQ_REPLY_TO;
+			}
+		}
+		return container;
+	}
+
 	@Nullable
 	private Message doSendAndReceiveAsListener(final String exchange, final String routingKey, final Message message,
 			@Nullable final CorrelationData correlationData, Channel channel, boolean noCorrelation) throws Exception { // NOSONAR