GH-1295: Reduce Method Complexity

garyrussell · garyrussell · commit e8e1b8638e46 · 2021-05-07T09:42:54.000-04:00
diff --git a/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/DelegatingInvocableHandler.java b/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/DelegatingInvocableHandler.java
@@ -267,6 +267,12 @@ protected boolean matchHandlerMethod(Class<? extends Object> payloadClass, Invoc
 				return true;
 			}
 		}
+		return findACandidate(payloadClass, handler, method, parameterAnnotations);
+	}
+
+	private boolean findACandidate(Class<? extends Object> payloadClass, InvocableHandlerMethod handler, Method method,
+			Annotation[][] parameterAnnotations) {
+
 		boolean foundCandidate = false;
 		for (int i = 0; i < parameterAnnotations.length; i++) {
 			MethodParameter methodParameter = new MethodParameter(method, i);

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,12 @@ protected boolean matchHandlerMethod(Class<? extends Object> payloadClass, Invoc`
`267`	`267`	`return true;`
`268`	`268`	`}`
`269`	`269`	`}`
	`270`	`+ return findACandidate(payloadClass, handler, method, parameterAnnotations);`
	`271`	`+ }`
	`272`	`+`
	`273`	`+ private boolean findACandidate(Class<? extends Object> payloadClass, InvocableHandlerMethod handler, Method method,`
	`274`	`+ Annotation[][] parameterAnnotations) {`
	`275`	`+`
`270`	`276`	`boolean foundCandidate = false;`
`271`	`277`	`for (int i = 0; i < parameterAnnotations.length; i++) {`
`272`	`278`	`MethodParameter methodParameter = new MethodParameter(method, i);`