Change default skip policy to NeverSkipItemSkipPolicy

Resolves #5077

Author: fmbenhassine

spring-batch-core/src/main/java/org/springframework/batch/core/step/builder/ChunkOrientedStepBuilder.java

@@ -48,7 +48,7 @@
 import org.springframework.batch.core.step.StepInterruptionPolicy;
 import org.springframework.batch.core.step.ThreadStepInterruptionPolicy;
 import org.springframework.batch.core.step.item.ChunkOrientedStep;
-import org.springframework.batch.core.step.skip.AlwaysSkipItemSkipPolicy;
+import org.springframework.batch.core.step.skip.NeverSkipItemSkipPolicy;
 import org.springframework.batch.core.step.skip.LimitCheckingExceptionHierarchySkipPolicy;
 import org.springframework.batch.core.step.skip.SkipLimitExceededException;
 import org.springframework.batch.core.step.skip.SkipPolicy;
@@ -320,7 +320,7 @@ public ChunkOrientedStepBuilder<I, O> retryLimit(long retryLimit) {
 	 * Set the skip policy for the step. This policy determines how the step handles
 	 * skipping items in case of failures. It can be used to define the conditions under
 	 * which items should be skipped and how many times an item can be skipped before the
-	 * step fails. Defaults to {@link AlwaysSkipItemSkipPolicy}.
+	 * step fails. Defaults to {@link NeverSkipItemSkipPolicy}.
 	 * @param skipPolicy the skip policy to use
 	 * @return this for fluent chaining
 	 */
@@ -425,7 +425,7 @@ public ChunkOrientedStep<I, O> build() {
 						this.skipLimit);
 			}
 			else {
-				this.skipPolicy = new AlwaysSkipItemSkipPolicy();
+				this.skipPolicy = new NeverSkipItemSkipPolicy();
 			}
 		}
 		chunkOrientedStep.setSkipPolicy(this.skipPolicy);

spring-batch-core/src/main/java/org/springframework/batch/core/step/item/ChunkOrientedStep.java

@@ -50,7 +50,7 @@
 import org.springframework.batch.core.step.FatalStepExecutionException;
 import org.springframework.batch.core.step.StepInterruptionPolicy;
 import org.springframework.batch.core.step.ThreadStepInterruptionPolicy;
-import org.springframework.batch.core.step.skip.AlwaysSkipItemSkipPolicy;
+import org.springframework.batch.core.step.skip.NeverSkipItemSkipPolicy;
 import org.springframework.batch.core.step.skip.SkipPolicy;
 import org.springframework.batch.infrastructure.item.Chunk;
 import org.springframework.batch.infrastructure.item.ExecutionContext;
@@ -143,7 +143,7 @@ public class ChunkOrientedStep<I, O> extends AbstractStep {
 
 	private final CompositeRetryListener compositeRetryListener = new CompositeRetryListener();
 
-	private SkipPolicy skipPolicy = new AlwaysSkipItemSkipPolicy();
+	private SkipPolicy skipPolicy = new NeverSkipItemSkipPolicy();
 
 	private final CompositeSkipListener<I, O> compositeSkipListener = new CompositeSkipListener<>();
 
@@ -297,7 +297,7 @@ public void registerRetryListener(RetryListener retryListener) {
 	 * whether an item should be skipped or not when an exception occurs during item
 	 * processing.
 	 * @param skipPolicy the skip policy to set. Defaults to
-	 * {@link AlwaysSkipItemSkipPolicy}.
+	 * {@link NeverSkipItemSkipPolicy}.
 	 */
 	public void setSkipPolicy(SkipPolicy skipPolicy) {
 		Assert.notNull(skipPolicy, "Skip policy must not be null");