Skip to content

Commit 1706e74

Browse files
committed
Revert "Work around circular dependency regression in Security"
This reverts commit 20a4e6f. See gh-45492
1 parent 912b50e commit 1706e74

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

spring-boot-project/spring-boot-security-oauth2-client/src/main/java/org/springframework/boot/security/oauth2/client/autoconfigure/servlet/OAuth2ClientWebSecurityAutoConfiguration.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import org.springframework.context.annotation.Configuration;
3131
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
3232
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
33-
import org.springframework.security.config.web.PathPatternRequestMatcherBuilderFactoryBean;
3433
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientService;
3534
import org.springframework.security.oauth2.client.web.AuthenticatedPrincipalOAuth2AuthorizedClientRepository;
3635
import org.springframework.security.oauth2.client.web.OAuth2AuthorizedClientRepository;
@@ -53,12 +52,6 @@
5352
@ConditionalOnWebApplication(type = Type.SERVLET)
5453
public class OAuth2ClientWebSecurityAutoConfiguration {
5554

56-
@Bean
57-
@ConditionalOnMissingBean(name = "workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder")
58-
PathPatternRequestMatcherBuilderFactoryBean workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder() {
59-
return new PathPatternRequestMatcherBuilderFactoryBean();
60-
}
61-
6255
@Bean
6356
@ConditionalOnMissingBean
6457
OAuth2AuthorizedClientRepository authorizedClientRepository(OAuth2AuthorizedClientService authorizedClientService) {

spring-boot-project/spring-boot-security-oauth2-resource-server/src/main/java/org/springframework/boot/security/oauth2/server/resource/autoconfigure/servlet/OAuth2ResourceServerAutoConfiguration.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,14 @@
1919
import org.springframework.boot.autoconfigure.AutoConfiguration;
2020
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
22-
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2322
import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
2423
import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication.Type;
2524
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2625
import org.springframework.boot.security.autoconfigure.actuate.servlet.ManagementWebSecurityAutoConfiguration;
2726
import org.springframework.boot.security.autoconfigure.servlet.SecurityAutoConfiguration;
2827
import org.springframework.boot.security.autoconfigure.servlet.UserDetailsServiceAutoConfiguration;
2928
import org.springframework.boot.security.oauth2.server.resource.autoconfigure.OAuth2ResourceServerProperties;
30-
import org.springframework.context.annotation.Bean;
3129
import org.springframework.context.annotation.Import;
32-
import org.springframework.security.config.web.PathPatternRequestMatcherBuilderFactoryBean;
3330
import org.springframework.security.oauth2.server.resource.authentication.BearerTokenAuthenticationToken;
3431

3532
/**
@@ -47,10 +44,4 @@
4744
Oauth2ResourceServerConfiguration.OpaqueTokenConfiguration.class })
4845
public class OAuth2ResourceServerAutoConfiguration {
4946

50-
@Bean
51-
@ConditionalOnMissingBean(name = "workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder")
52-
PathPatternRequestMatcherBuilderFactoryBean workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder() {
53-
return new PathPatternRequestMatcherBuilderFactoryBean();
54-
}
55-
5647
}

spring-boot-project/spring-boot-security/src/main/java/org/springframework/boot/security/autoconfigure/servlet/SpringBootWebSecurityConfiguration.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.springframework.security.config.BeanIds;
3434
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
3535
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
36-
import org.springframework.security.config.web.PathPatternRequestMatcherBuilderFactoryBean;
3736
import org.springframework.security.web.SecurityFilterChain;
3837
import org.springframework.security.web.servlet.util.matcher.PathPatternRequestMatcher;
3938

@@ -48,12 +47,6 @@
4847
@ConditionalOnWebApplication(type = Type.SERVLET)
4948
class SpringBootWebSecurityConfiguration {
5049

51-
@Bean
52-
@ConditionalOnMissingBean(name = "workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder")
53-
PathPatternRequestMatcherBuilderFactoryBean workAroundSecurityDependencyCyclePathPatternRequestMatcherBuilder() {
54-
return new PathPatternRequestMatcherBuilderFactoryBean();
55-
}
56-
5750
@Configuration(proxyBeanMethods = false)
5851
@ConditionalOnBean(DispatcherServletPath.class)
5952
@ConditionalOnClass(DispatcherServletPath.class)

0 commit comments

Comments
 (0)