Upgrade to Elasticsearch Client 8.17.1

nosan · nosan · commit 182621081348 · 2025-02-05T00:36:35.000+02:00
Signed-off-by: Dmytro Nosan &lt;dimanosan@gmail.com&gt;
diff --git a/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/data/elasticsearch/ElasticsearchReactiveHealthIndicator.java b/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/data/elasticsearch/ElasticsearchReactiveHealthIndicator.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2022 the original author or authors.
+ * Copyright 2012-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -69,6 +69,7 @@ private Health processResponse(Health.Builder builder, HealthResponse response)
 			builder.withDetail("task_max_waiting_in_queue_millis", response.taskMaxWaitingInQueueMillis());
 			builder.withDetail("active_shards_percent_as_number",
 					Double.parseDouble(response.activeShardsPercentAsNumber()));
+			builder.withDetail("unassigned_primary_shards", response.unassignedPrimaryShards());
 			return builder.build();
 		}
 		return builder.down().build();
diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/elasticsearch/ElasticsearchReactiveHealthIndicatorTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/elasticsearch/ElasticsearchReactiveHealthIndicatorTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -72,15 +72,15 @@ void shutdown() throws Exception {
 
 	@Test
 	void elasticsearchIsUp() {
-		setupMockResponse(200, "green");
+		setupMockResponse("green");
 		Health health = this.healthIndicator.health().block(TIMEOUT);
 		assertThat(health.getStatus()).isEqualTo(Status.UP);
 		assertHealthDetailsWithStatus(health.getDetails(), "green");
 	}
 
 	@Test
 	void elasticsearchWithYellowStatusIsUp() {
-		setupMockResponse(200, "yellow");
+		setupMockResponse("yellow");
 		Health health = this.healthIndicator.health().block(TIMEOUT);
 		assertThat(health.getStatus()).isEqualTo(Status.UP);
 		assertHealthDetailsWithStatus(health.getDetails(), "yellow");
@@ -104,7 +104,7 @@ void elasticsearchIsDownByResponseCode() {
 
 	@Test
 	void elasticsearchIsOutOfServiceByStatus() {
-		setupMockResponse(200, "red");
+		setupMockResponse("red");
 		Health health = this.healthIndicator.health().block(TIMEOUT);
 		assertThat(health.getStatus()).isEqualTo(Status.OUT_OF_SERVICE);
 		assertHealthDetailsWithStatus(health.getDetails(), "red");
@@ -116,10 +116,11 @@ private void assertHealthDetailsWithStatus(Map<String, Object> details, String s
 				entry("active_primary_shards", 0), entry("active_shards", 0), entry("relocating_shards", 0),
 				entry("initializing_shards", 0), entry("unassigned_shards", 0), entry("delayed_unassigned_shards", 0),
 				entry("number_of_pending_tasks", 0), entry("number_of_in_flight_fetch", 0),
-				entry("task_max_waiting_in_queue_millis", 0L), entry("active_shards_percent_as_number", 100.0));
+				entry("task_max_waiting_in_queue_millis", 0L), entry("active_shards_percent_as_number", 100.0),
+				entry("unassigned_primary_shards", 10));
 	}
 
-	private void setupMockResponse(int responseCode, String status) {
+	private void setupMockResponse(String status) {
 		MockResponse mockResponse = new MockResponse().setBody(createJsonResult(status))
 			.setHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE)
 			.setHeader("X-Elastic-Product", "Elasticsearch");
@@ -133,7 +134,8 @@ private String createJsonResult(String status) {
 						+ "\"active_shards\":0,\"relocating_shards\":0,\"initializing_shards\":0,"
 						+ "\"unassigned_shards\":0,\"delayed_unassigned_shards\":0,"
 						+ "\"number_of_pending_tasks\":0,\"number_of_in_flight_fetch\":0,"
-						+ "\"task_max_waiting_in_queue_millis\":0,\"active_shards_percent_as_number\":100.0}",
+						+ "\"task_max_waiting_in_queue_millis\":0,\"active_shards_percent_as_number\":100.0,"
+						+ "\"unassigned_primary_shards\": 10 }",
 				status);
 	}
 
diff --git a/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/elasticsearch/ElasticsearchRestClientHealthIndicatorTests.java b/spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/elasticsearch/ElasticsearchRestClientHealthIndicatorTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2022 the original author or authors.
+ * Copyright 2012-2025 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -122,20 +122,20 @@ private void assertHealthDetailsWithStatus(Map<String, Object> details, String s
 				entry("active_primary_shards", 0), entry("active_shards", 0), entry("relocating_shards", 0),
 				entry("initializing_shards", 0), entry("unassigned_shards", 0), entry("delayed_unassigned_shards", 0),
 				entry("number_of_pending_tasks", 0), entry("number_of_in_flight_fetch", 0),
-				entry("task_max_waiting_in_queue_millis", 0), entry("active_shards_percent_as_number", 100.0));
+				entry("task_max_waiting_in_queue_millis", 0), entry("active_shards_percent_as_number", 100.0),
+				entry("unassigned_primary_shards", 10));
 	}
 
 	private String createJsonResult(int responseCode, String status) {
 		if (responseCode == 200) {
-			return String.format(
-					"{\"cluster_name\":\"elasticsearch\","
-							+ "\"status\":\"%s\",\"timed_out\":false,\"number_of_nodes\":1,"
-							+ "\"number_of_data_nodes\":1,\"active_primary_shards\":0,"
-							+ "\"active_shards\":0,\"relocating_shards\":0,\"initializing_shards\":0,"
-							+ "\"unassigned_shards\":0,\"delayed_unassigned_shards\":0,"
-							+ "\"number_of_pending_tasks\":0,\"number_of_in_flight_fetch\":0,"
-							+ "\"task_max_waiting_in_queue_millis\":0,\"active_shards_percent_as_number\":100.0}",
-					status);
+			return String.format("{\"cluster_name\":\"elasticsearch\","
+					+ "\"status\":\"%s\",\"timed_out\":false,\"number_of_nodes\":1,"
+					+ "\"number_of_data_nodes\":1,\"active_primary_shards\":0,"
+					+ "\"active_shards\":0,\"relocating_shards\":0,\"initializing_shards\":0,"
+					+ "\"unassigned_shards\":0,\"delayed_unassigned_shards\":0,"
+					+ "\"number_of_pending_tasks\":0,\"number_of_in_flight_fetch\":0,"
+					+ "\"task_max_waiting_in_queue_millis\":0,\"active_shards_percent_as_number\":100.0,"
+					+ "\"unassigned_primary_shards\": 10 }", status);
 		}
 		return "{\n  \"error\": \"Server Error\",\n  \"status\": " + responseCode + "\n}";
 	}
diff --git a/spring-boot-project/spring-boot-dependencies/build.gradle b/spring-boot-project/spring-boot-dependencies/build.gradle
@@ -337,7 +337,7 @@ bom {
 			releaseNotes("https://github.com/ehcache/ehcache3/releases/tag/v{version}")
 		}
 	}
-	library("Elasticsearch Client", "8.15.5") {
+	library("Elasticsearch Client", "8.17.1") {
 		group("org.elasticsearch.client") {
 			modules = [
 				"elasticsearch-rest-client" {

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * Copyright 2012-2022 the original author or authors.`
	`2`	`+ * Copyright 2012-2025 the original author or authors.`
`3`	`3`	`*`
`4`	`4`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`5`	`5`	`* you may not use this file except in compliance with the License.`
`@@ -69,6 +69,7 @@ private Health processResponse(Health.Builder builder, HealthResponse response)`
`69`	`69`	`builder.withDetail("task_max_waiting_in_queue_millis", response.taskMaxWaitingInQueueMillis());`
`70`	`70`	`builder.withDetail("active_shards_percent_as_number",`
`71`	`71`	`Double.parseDouble(response.activeShardsPercentAsNumber()));`
	`72`	`+ builder.withDetail("unassigned_primary_shards", response.unassignedPrimaryShards());`
`72`	`73`	`return builder.build();`
`73`	`74`	`}`
`74`	`75`	`return builder.down().build();`
Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ bom {`
`337`	`337`	`releaseNotes("https://github.com/ehcache/ehcache3/releases/tag/v{version}")`
`338`	`338`	`}`
`339`	`339`	`}`
`340`		`- library("Elasticsearch Client", "8.15.5") {`
	`340`	`+ library("Elasticsearch Client", "8.17.1") {`
`341`	`341`	`group("org.elasticsearch.client") {`
`342`	`342`	`modules = [`
`343`	`343`	`"elasticsearch-rest-client" {`