Skip to content

Commit 18a4703

Browse files
committed
Disable Artemis tests on Java 23
The reason for this is that Artemis is not compatible yet with Java 23: https://issues.apache.org/jira/browse/ARTEMIS-4975 The following test classes are completely disabled on Java 23: - ArtemisAutoConfigurationTests - ArtemisEmbeddedConfigurationFactoryTests - ArtemisEnvironmentTests - JmsHealthContributorAutoConfigurationTests Besides that I disabled the tests with Artemis context in the following test class: - JmsAutoConfigurationTests Because the org.junit.jupiter.api.condition.JRE does not contain a JAVA_23 enum value yet, I used the EnabledForJreRange annotation and not the DisabledOnJre annotation. This should close #41909
1 parent 09e119b commit 18a4703

File tree

5 files changed

+16
-2
lines changed

5 files changed

+16
-2
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/jms/JmsHealthContributorAutoConfigurationTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package org.springframework.boot.actuate.autoconfigure.jms;
1818

1919
import org.junit.jupiter.api.Test;
20+
import org.junit.jupiter.api.condition.EnabledForJreRange;
21+
import org.junit.jupiter.api.condition.JRE;
2022

2123
import org.springframework.boot.actuate.autoconfigure.health.HealthContributorAutoConfiguration;
2224
import org.springframework.boot.actuate.jms.JmsHealthIndicator;
@@ -32,6 +34,7 @@
3234
*
3335
* @author Phillip Webb
3436
*/
37+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
3538
class JmsHealthContributorAutoConfigurationTests {
3639

3740
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/JmsAutoConfigurationTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
import jakarta.jms.Session;
2525
import org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory;
2626
import org.junit.jupiter.api.Test;
27+
import org.junit.jupiter.api.condition.EnabledForJreRange;
28+
import org.junit.jupiter.api.condition.JRE;
2729

2830
import org.springframework.aot.hint.predicate.RuntimeHintsPredicates;
2931
import org.springframework.aot.test.generate.TestGenerationContext;
@@ -72,6 +74,7 @@ class JmsAutoConfigurationTests {
7274
.withConfiguration(AutoConfigurations.of(ArtemisAutoConfiguration.class, JmsAutoConfiguration.class));
7375

7476
@Test
77+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
7578
void testDefaultJmsConfiguration() {
7679
this.contextRunner.withUserConfiguration(TestConfiguration.class).run((context) -> {
7780
assertThat(context).hasSingleBean(ConnectionFactory.class);
@@ -88,6 +91,7 @@ void testDefaultJmsConfiguration() {
8891
}
8992

9093
@Test
94+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
9195
void testConnectionFactoryBackOff() {
9296
this.contextRunner.withUserConfiguration(TestConfiguration2.class)
9397
.run((context) -> assertThat(context.getBeansOfType(ActiveMQConnectionFactory.class))
@@ -108,6 +112,7 @@ void testJmsMessagingTemplateBackOff() {
108112
}
109113

110114
@Test
115+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
111116
void testJmsTemplateBackOffEverything() {
112117
this.contextRunner
113118
.withUserConfiguration(TestConfiguration2.class, TestConfiguration3.class, TestConfiguration5.class)

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/artemis/ArtemisAutoConfigurationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
import org.apache.activemq.artemis.jms.server.config.impl.JMSQueueConfigurationImpl;
4242
import org.apache.activemq.artemis.jms.server.config.impl.TopicConfigurationImpl;
4343
import org.junit.jupiter.api.Test;
44-
import org.junit.jupiter.api.condition.DisabledOnJre;
44+
import org.junit.jupiter.api.condition.EnabledForJreRange;
4545
import org.junit.jupiter.api.condition.JRE;
4646
import org.junit.jupiter.api.io.TempDir;
4747
import org.messaginghub.pooled.jms.JmsPoolConnectionFactory;
@@ -66,7 +66,7 @@
6666
* @author Eddú Meléndez
6767
* @author Stephane Nicoll
6868
*/
69-
@DisabledOnJre(value = JRE.OTHER, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
69+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
7070
class ArtemisAutoConfigurationTests {
7171

7272
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/artemis/ArtemisEmbeddedConfigurationFactoryTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.apache.activemq.artemis.core.server.JournalType;
2626
import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
2727
import org.junit.jupiter.api.Test;
28+
import org.junit.jupiter.api.condition.EnabledForJreRange;
29+
import org.junit.jupiter.api.condition.JRE;
2830

2931
import static org.assertj.core.api.Assertions.assertThat;
3032

@@ -35,6 +37,7 @@
3537
* @author Stephane Nicoll
3638
* @author Phillip Webb
3739
*/
40+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
3841
class ArtemisEmbeddedConfigurationFactoryTests {
3942

4043
@Test

spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/activemq/ArtemisEnvironmentTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import java.util.Map;
2121

2222
import org.junit.jupiter.api.Test;
23+
import org.junit.jupiter.api.condition.EnabledForJreRange;
24+
import org.junit.jupiter.api.condition.JRE;
2325

2426
import static org.assertj.core.api.Assertions.assertThat;
2527

@@ -28,6 +30,7 @@
2830
*
2931
* @author Eddú Meléndez
3032
*/
33+
@EnabledForJreRange(max = JRE.JAVA_22, disabledReason = "https://issues.apache.org/jira/browse/ARTEMIS-4975")
3134
class ArtemisEnvironmentTests {
3235

3336
@Test

0 commit comments

Comments
 (0)