Correct SCM URLs in published poms

Previously, Maven's default behaviour was relied up which resulted
in the artifact ID being appended to each URL as it was inherited.
This behaviour can only be disabled in Maven 3.6 and later, a version
that we cannot use due to an incompatibility with the Flatten Plugin.

This commit works around Maven's default behaviour by defining
properties for the SCM URL, connection, and developer connection and
then explicitly defining the settings in each pom using these
properties. The explicit definition of the properties in each pom
prevents them being inherited from the parent, thereby disabling the
unwanted appending of the artifact ID to the URL.

Fixes gh-18328

Author: wilkinsona

spring-boot-project/spring-boot-actuator-autoconfigure/pom.xml

@@ -15,6 +15,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-actuator/pom.xml

@@ -15,6 +15,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-autoconfigure/pom.xml

@@ -15,6 +15,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-cli/pom.xml

@@ -18,6 +18,11 @@
 		<spring.profiles.active>default</spring.profiles.active>
 		<generated.pom.dir>${project.build.directory}/generated-resources/org/springframework/boot/cli/compiler/dependencies</generated.pom.dir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-devtools/pom.xml

@@ -13,6 +13,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-docs/pom.xml

@@ -14,6 +14,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<dependency>
 			<groupId>org.springframework.boot</groupId>

spring-boot-project/spring-boot-parent/pom.xml

@@ -20,6 +20,9 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 		<disable.checks>false</disable.checks>
+		<git.url>https://github.com/spring-projects/spring-boot</git.url>
+		<git.connection>scm:git:git://github.com/spring-projects/spring-boot.git</git.connection>
+		<git.developerConnection>scm:git:ssh://[email protected]/spring-projects/spring-boot.git</git.developerConnection>
 		<java.version>1.8</java.version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
@@ -29,9 +32,9 @@
 		<testcontainers.version>1.10.6</testcontainers.version>
 	</properties>
 	<scm>
-		<url>https://github.com/spring-projects/spring-boot</url>
-		<connection>scm:git:git://github.com/spring-projects/spring-boot.git</connection>
-		<developerConnection>scm:git:ssh://[email protected]/spring-projects/spring-boot.git</developerConnection>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
 	</scm>
 	<issueManagement>
 		<system>Github</system>

spring-boot-project/spring-boot-properties-migrator/pom.xml

@@ -14,6 +14,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<!-- Compile -->
 		<dependency>

spring-boot-project/spring-boot-starters/pom.xml

@@ -16,6 +16,11 @@
 	<properties>
 		<main.basedir>${basedir}/../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<modules>
 		<module>spring-boot-starter</module>
 		<module>spring-boot-starter-activemq</module>

spring-boot-project/spring-boot-starters/spring-boot-starter-activemq/pom.xml

@@ -13,6 +13,11 @@
 	<properties>
 		<main.basedir>${basedir}/../../..</main.basedir>
 	</properties>
+	<scm>
+		<url>${git.url}</url>
+		<connection>${git.connection}</connection>
+		<developerConnection>${git.developerConnection}</developerConnection>
+	</scm>
 	<dependencies>
 		<dependency>
 			<groupId>org.springframework.boot</groupId>