Skip to content

Commit 445589a

Browse files
author
Phillip Webb
committed
Polish RabbitMQ Changes
Fix the formatting which was messed up in commit ad1636f. Also simplify the RabbitProperties.setVirtualHost logic a little See gh-1128
1 parent ad1636f commit 445589a

File tree

3 files changed

+34
-38
lines changed

3 files changed

+34
-38
lines changed

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
/**
2323
* Configuration properties for Rabbit.
24-
*
24+
*
2525
* @author Greg Turnquist
2626
* @author Dave Syer
2727
*/
@@ -110,15 +110,11 @@ public String getVirtualHost() {
110110
}
111111

112112
public void setVirtualHost(String virtualHost) {
113-
if ("".equals(virtualHost) || virtualHost.equals("/")) {
114-
this.virtualHost = "/";
115-
} else {
116-
// remove all trailing /
117-
while (virtualHost.startsWith("/") && virtualHost.length() > 0) {
118-
virtualHost = virtualHost.substring(1);
119-
}
120-
this.virtualHost = virtualHost;
121-
}
113+
while (virtualHost.startsWith("/") && virtualHost.length() > 0) {
114+
virtualHost = virtualHost.substring(1);
115+
}
116+
this.virtualHost = ("".equals(virtualHost) ? "/" : virtualHost);
117+
122118
}
123119

124120
}

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/amqp/RabbitAutoconfigurationTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
package org.springframework.boot.autoconfigure.amqp;
1818

19-
import static org.junit.Assert.assertEquals;
20-
import static org.junit.Assert.assertNotNull;
21-
2219
import org.junit.Rule;
2320
import org.junit.Test;
2421
import org.junit.rules.ExpectedException;
@@ -33,9 +30,12 @@
3330
import org.springframework.context.annotation.Bean;
3431
import org.springframework.context.annotation.Configuration;
3532

33+
import static org.junit.Assert.assertEquals;
34+
import static org.junit.Assert.assertNotNull;
35+
3636
/**
3737
* Tests for {@link RabbitAutoConfiguration}.
38-
*
38+
*
3939
* @author Greg Turnquist
4040
*/
4141
public class RabbitAutoconfigurationTests {
@@ -74,7 +74,7 @@ public void testRabbitTemplateWithOverrides() {
7474
.getBean(CachingConnectionFactory.class);
7575
assertEquals("remote-server", connectionFactory.getHost());
7676
assertEquals(9000, connectionFactory.getPort());
77-
assertEquals("vhost", connectionFactory.getVirtualHost());
77+
assertEquals("vhost", connectionFactory.getVirtualHost());
7878
}
7979

8080
@Test

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/amqp/RabbitPropertiesTests.java

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@
1616

1717
package org.springframework.boot.autoconfigure.amqp;
1818

19+
import org.junit.Test;
20+
1921
import static org.junit.Assert.assertEquals;
2022
import static org.junit.Assert.assertNull;
2123

22-
import org.junit.Test;
23-
2424
/**
2525
* Tests for {@link RabbitProperties}.
26-
*
26+
*
2727
* @author Dave Syer
2828
*/
2929
public class RabbitPropertiesTests {
@@ -50,28 +50,28 @@ public void addressesDoubleValued() {
5050
assertEquals(9999, this.properties.getPort());
5151
}
5252

53-
@Test
54-
public void testDefaultVirtualHost() {
55-
this.properties.setVirtualHost("/");
56-
assertEquals("/", this.properties.getVirtualHost());
57-
}
53+
@Test
54+
public void testDefaultVirtualHost() {
55+
this.properties.setVirtualHost("/");
56+
assertEquals("/", this.properties.getVirtualHost());
57+
}
5858

59-
@Test
60-
public void testemptyVirtualHost() {
61-
this.properties.setVirtualHost("");
62-
assertEquals("/", this.properties.getVirtualHost());
63-
}
59+
@Test
60+
public void testemptyVirtualHost() {
61+
this.properties.setVirtualHost("");
62+
assertEquals("/", this.properties.getVirtualHost());
63+
}
6464

65-
@Test
66-
public void testCustomVirtualHost() {
67-
this.properties.setVirtualHost("myvHost");
68-
assertEquals("myvHost", this.properties.getVirtualHost());
69-
}
65+
@Test
66+
public void testCustomVirtualHost() {
67+
this.properties.setVirtualHost("myvHost");
68+
assertEquals("myvHost", this.properties.getVirtualHost());
69+
}
7070

71-
@Test
72-
public void testCustomFalsyVirtualHost() {
73-
this.properties.setVirtualHost("/myvHost");
74-
assertEquals("myvHost", this.properties.getVirtualHost());
75-
}
71+
@Test
72+
public void testCustomFalsyVirtualHost() {
73+
this.properties.setVirtualHost("/myvHost");
74+
assertEquals("myvHost", this.properties.getVirtualHost());
75+
}
7676

7777
}

0 commit comments

Comments
 (0)