Skip to content

Commit 4bb13bc

Browse files
committed
Fix package tangles in spring-boot-autoconfigure
See gh-17299
1 parent 1494deb commit 4bb13bc

File tree

5 files changed

+14
-18
lines changed

5 files changed

+14
-18
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceTransactionManagerAutoConfiguration.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,11 +19,13 @@
1919
import javax.sql.DataSource;
2020

2121
import org.springframework.beans.factory.ObjectProvider;
22+
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
2223
import org.springframework.boot.autoconfigure.AutoConfigureOrder;
2324
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2425
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2526
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2627
import org.springframework.boot.autoconfigure.condition.ConditionalOnSingleCandidate;
28+
import org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration;
2729
import org.springframework.boot.autoconfigure.transaction.TransactionManagerCustomizers;
2830
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2931
import org.springframework.context.annotation.Bean;
@@ -47,6 +49,7 @@
4749
@Configuration(proxyBeanMethods = false)
4850
@ConditionalOnClass({ JdbcTemplate.class, TransactionManager.class })
4951
@AutoConfigureOrder(Ordered.LOWEST_PRECEDENCE)
52+
@AutoConfigureBefore(TransactionAutoConfiguration.class)
5053
@EnableConfigurationProperties(DataSourceProperties.class)
5154
public class DataSourceTransactionManagerAutoConfiguration {
5255

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfiguration.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -21,9 +21,11 @@
2121
import org.hibernate.engine.spi.SessionImplementor;
2222

2323
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
24+
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
2425
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2526
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2627
import org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration;
28+
import org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration;
2729
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2830
import org.springframework.context.annotation.Configuration;
2931
import org.springframework.context.annotation.Import;
@@ -41,7 +43,8 @@
4143
@Configuration(proxyBeanMethods = false)
4244
@ConditionalOnClass({ LocalContainerEntityManagerFactoryBean.class, EntityManager.class, SessionImplementor.class })
4345
@EnableConfigurationProperties(JpaProperties.class)
44-
@AutoConfigureAfter({ DataSourceAutoConfiguration.class })
46+
@AutoConfigureAfter(DataSourceAutoConfiguration.class)
47+
@AutoConfigureBefore(TransactionAutoConfiguration.class)
4548
@Import(HibernateJpaConfiguration.class)
4649
public class HibernateJpaAutoConfiguration {
4750

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/SqlInitializationAutoConfiguration.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -16,12 +16,9 @@
1616

1717
package org.springframework.boot.autoconfigure.sql.init;
1818

19-
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2019
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2120
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2221
import org.springframework.boot.autoconfigure.condition.NoneNestedConditions;
23-
import org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration;
24-
import org.springframework.boot.autoconfigure.r2dbc.R2dbcAutoConfiguration;
2522
import org.springframework.boot.autoconfigure.sql.init.SqlInitializationAutoConfiguration.SqlInitializationModeCondition;
2623
import org.springframework.boot.context.properties.EnableConfigurationProperties;
2724
import org.springframework.boot.sql.init.dependency.DatabaseInitializationDependencyConfigurer;
@@ -36,7 +33,6 @@
3633
* @since 2.5.0
3734
*/
3835
@Configuration(proxyBeanMethods = false)
39-
@AutoConfigureAfter({ R2dbcAutoConfiguration.class, DataSourceAutoConfiguration.class })
4036
@EnableConfigurationProperties(SqlInitializationProperties.class)
4137
@Import({ DatabaseInitializationDependencyConfigurer.class, R2dbcInitializationConfiguration.class,
4238
DataSourceInitializationConfiguration.class })

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/transaction/TransactionAutoConfiguration.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -19,16 +19,11 @@
1919
import java.util.stream.Collectors;
2020

2121
import org.springframework.beans.factory.ObjectProvider;
22-
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
2322
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
2423
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2726
import org.springframework.boot.autoconfigure.condition.ConditionalOnSingleCandidate;
28-
import org.springframework.boot.autoconfigure.data.neo4j.Neo4jDataAutoConfiguration;
29-
import org.springframework.boot.autoconfigure.jdbc.DataSourceTransactionManagerAutoConfiguration;
30-
import org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaAutoConfiguration;
31-
import org.springframework.boot.autoconfigure.transaction.jta.JtaAutoConfiguration;
3227
import org.springframework.boot.context.properties.EnableConfigurationProperties;
3328
import org.springframework.context.annotation.Bean;
3429
import org.springframework.context.annotation.Configuration;
@@ -50,8 +45,6 @@
5045
*/
5146
@Configuration(proxyBeanMethods = false)
5247
@ConditionalOnClass(PlatformTransactionManager.class)
53-
@AutoConfigureAfter({ JtaAutoConfiguration.class, HibernateJpaAutoConfiguration.class,
54-
DataSourceTransactionManagerAutoConfiguration.class, Neo4jDataAutoConfiguration.class })
5548
@EnableConfigurationProperties(TransactionProperties.class)
5649
public class TransactionAutoConfiguration {
5750

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/transaction/jta/JtaAutoConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2021 the original author or authors.
2+
* Copyright 2012-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
2424
import org.springframework.boot.autoconfigure.jms.activemq.ActiveMQAutoConfiguration;
2525
import org.springframework.boot.autoconfigure.jms.artemis.ArtemisAutoConfiguration;
2626
import org.springframework.boot.autoconfigure.orm.jpa.HibernateJpaAutoConfiguration;
27+
import org.springframework.boot.autoconfigure.transaction.TransactionAutoConfiguration;
2728
import org.springframework.context.annotation.Configuration;
2829
import org.springframework.context.annotation.Import;
2930

@@ -39,7 +40,7 @@
3940
@ConditionalOnClass(javax.transaction.Transaction.class)
4041
@ConditionalOnProperty(prefix = "spring.jta", value = "enabled", matchIfMissing = true)
4142
@AutoConfigureBefore({ XADataSourceAutoConfiguration.class, ActiveMQAutoConfiguration.class,
42-
ArtemisAutoConfiguration.class, HibernateJpaAutoConfiguration.class })
43+
ArtemisAutoConfiguration.class, HibernateJpaAutoConfiguration.class, TransactionAutoConfiguration.class })
4344
@Import({ JndiJtaConfiguration.class, AtomikosJtaConfiguration.class })
4445
public class JtaAutoConfiguration {
4546

0 commit comments

Comments
 (0)