Skip to content

Commit 4bc5535

Browse files
committed
Rework "Remove redundant spring-boot-starter dependency"
This commit reworks 40d8726 as it has introduced an unfortunate side effect for those who are using a starter with optional starter dependencies. `spring-boot-starter-web` defines the json and the tomcat starter. The latter is part of a set of starters that do not bring the base starter and the former can be excluded to use gson rather than jackson. When such arrangement happens, spring-boot-starter-web no longer defines the base starter (and therefore doesn't bring the core dependencies that Spring Boot needs to bootstrap). This commit reviews the starters that define optional starters and reintroduce the base starter. Closes gh-14076
1 parent fe05fed commit 4bc5535

File tree

4 files changed

+16
-4
lines changed
  • spring-boot-project/spring-boot-starters

4 files changed

+16
-4
lines changed

spring-boot-project/spring-boot-starters/spring-boot-starter-batch/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
<main.basedir>${basedir}/../../..</main.basedir>
1515
</properties>
1616
<dependencies>
17+
<dependency>
18+
<groupId>org.springframework.boot</groupId>
19+
<artifactId>spring-boot-starter</artifactId>
20+
</dependency>
1721
<dependency>
1822
<groupId>org.springframework.boot</groupId>
1923
<artifactId>spring-boot-starter-jdbc</artifactId>

spring-boot-project/spring-boot-starters/spring-boot-starter-web-services/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
<main.basedir>${basedir}/../../..</main.basedir>
1515
</properties>
1616
<dependencies>
17+
<dependency>
18+
<groupId>org.springframework.boot</groupId>
19+
<artifactId>spring-boot-starter-web</artifactId>
20+
</dependency>
1721
<dependency>
1822
<groupId>com.sun.xml.messaging.saaj</groupId>
1923
<artifactId>saaj-impl</artifactId>
@@ -22,10 +26,6 @@
2226
<groupId>javax.xml.ws</groupId>
2327
<artifactId>jaxws-api</artifactId>
2428
</dependency>
25-
<dependency>
26-
<groupId>org.springframework.boot</groupId>
27-
<artifactId>spring-boot-starter-web</artifactId>
28-
</dependency>
2929
<dependency>
3030
<groupId>org.springframework</groupId>
3131
<artifactId>spring-oxm</artifactId>

spring-boot-project/spring-boot-starters/spring-boot-starter-web/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
<main.basedir>${basedir}/../../..</main.basedir>
1616
</properties>
1717
<dependencies>
18+
<dependency>
19+
<groupId>org.springframework.boot</groupId>
20+
<artifactId>spring-boot-starter</artifactId>
21+
</dependency>
1822
<dependency>
1923
<groupId>org.springframework.boot</groupId>
2024
<artifactId>spring-boot-starter-json</artifactId>

spring-boot-project/spring-boot-starters/spring-boot-starter-webflux/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
<main.basedir>${basedir}/../../..</main.basedir>
1616
</properties>
1717
<dependencies>
18+
<dependency>
19+
<groupId>org.springframework.boot</groupId>
20+
<artifactId>spring-boot-starter</artifactId>
21+
</dependency>
1822
<dependency>
1923
<groupId>org.springframework.boot</groupId>
2024
<artifactId>spring-boot-starter-json</artifactId>

0 commit comments

Comments
 (0)